feat: derive some common traits on some UI types #12532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwsmm
commented
Mar 17, 2024
Comment on lines
-21
to
-29
| impl Default for Text { | ||
| fn default() -> Self { | ||
| Self { | ||
| sections: Default::default(), | ||
| justify: JustifyText::Left, | ||
| linebreak_behavior: BreakLineOn::WordBoundary, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
BreakLineOn::WordBoundary is now the Default value, so impl Default for Text can be derived automatically
awwsmm
commented
Mar 17, 2024
| @@ -1796,7 +1796,7 @@ pub struct CalculatedClip { | |||
| /// `ZIndex::Local(n)` and `ZIndex::Global(n)` for root nodes. | |||
| /// | |||
| /// Nodes without this component will be treated as if they had a value of `ZIndex::Local(0)`. | |||
| #[derive(Component, Copy, Clone, Debug, Reflect)] | |||
There was a problem hiding this comment.
ZIndex can impl Eq because its variants are just newtypes around i32s
awwsmm
commented
Mar 17, 2024
| @@ -4,6 +4,6 @@ use bevy_reflect::std_traits::ReflectDefault; | |||
| use bevy_reflect::Reflect; | |||
|
|
|||
| /// Marker struct for buttons | |||
| #[derive(Component, Debug, Default, Clone, Copy, Reflect)] | |||
There was a problem hiding this comment.
Marker components can trivially impl many traits
NthTensor
added
A-UI
alice-i-cecile
approved these changes
Mar 17, 2024
james7132
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
PartialEqfor comparing simple typesSolution
derives for some common UI typesNote that many types, unfortunately, can't have
PartialEqderived for them, because they containf32s and / orVecs.